[Fix] no-multi-comp: correctly ignore wrapped stateless components

Fixes #2145
jsx-eslint · Jan 27, 2019 · 6a68f09 · 6a68f09
1 parent 9497745
commit 6a68f09
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/lib/rules/no-multi-comp.js b/lib/rules/no-multi-comp.js
@@ -32,7 +32,7 @@ module.exports = {
     }]
   },
 
-  create: Components.detect((context, components) => {
+  create: Components.detect((context, components, utils) => {
     const configuration = context.options[0] || {};
     const ignoreStateless = configuration.ignoreStateless || false;
 
@@ -44,7 +44,12 @@ module.exports = {
      * @returns {Boolean} True if the component is ignored, false if not.
      */
     function isIgnored(component) {
-      return ignoreStateless && /Function/.test(component.node.type);
+      return (
+        ignoreStateless && (
+          /Function/.test(component.node.type) ||
+          utils.isPragmaComponentWrapper(component.node)
+        )
+      );
     }
 
     // --------------------------------------------------------------------------

diff --git a/tests/lib/rules/no-multi-comp.js b/tests/lib/rules/no-multi-comp.js
@@ -99,6 +99,20 @@ ruleTester.run('no-multi-comp', rule, {
       '};'
     ].join('\n'),
     parserOptions: Object.assign({sourceType: 'module'}, parserOptions)
+  }, {
+    code: `
+      const Hello = React.memo(function(props) {
+        return <div>Hello {props.name}</div>;
+      });
+      class HelloJohn extends React.Component {
+        render() {
+          return <Hello name="John" />;
+        }
+      }
+    `,
+    options: [{
+      ignoreStateless: true
+    }]
   }],
 
   invalid: [{