[Fix] jsx-no-target-blank: don’t crash when there’s no value

Fixes #1949.
jsx-eslint · Aug 21, 2018 · 72a71b3 · 72a71b3
1 parent 6b239a7
commit 72a71b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js
@@ -11,7 +11,9 @@ const docsUrl = require('../util/docsUrl');
 // ------------------------------------------------------------------------------
 
 function isTargetBlank(attr) {
-  return attr.name.name === 'target' &&
+  return attr.name &&
+    attr.name.name === 'target' &&
+    attr.value &&
     attr.value.type === 'Literal' &&
     attr.value.value.toLowerCase() === '_blank';
 }

diff --git a/tests/lib/rules/jsx-no-target-blank.js b/tests/lib/rules/jsx-no-target-blank.js
@@ -33,6 +33,7 @@ ruleTester.run('jsx-no-target-blank', rule, {
   valid: [
     {code: '<a href="foobar"></a>'},
     {code: '<a randomTag></a>'},
+    {code: '<a target />'},
     {code: '<a href="foobar" target="_blank" rel="noopener noreferrer"></a>'},
     {code: '<a target="_blank" {...spreadProps} rel="noopener noreferrer"></a>'},
     {code: '<a {...spreadProps} target="_blank" rel="noopener noreferrer" href="http://example.com">s</a>'},