Merge pull request #2090 from JBallin/no-method-set-state-docs-url

Fix noMethodSetState docsUrl's
jsx-eslint · Dec 18, 2018 · 77e3fd0 · 77e3fd0
2 parents 9358489 + 7da9e0d
commit 77e3fd0
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/lib/util/makeNoMethodSetStateRule.js b/lib/util/makeNoMethodSetStateRule.js
@@ -10,14 +10,27 @@ const docsUrl = require('./docsUrl');
 // Rule Definition
 // ------------------------------------------------------------------------------
 
+function mapTitle(methodName) {
+  const map = {
+    componentDidMount: 'did-mount',
+    componentDidUpdate: 'did-update',
+    componentWillUpdate: 'will-update'
+  };
+  const title = map[methodName];
+  if (!title) {
+    throw Error(`No docsUrl for '${methodName}'`);
+  }
+  return `no-${title}-set-state`;
+}
+
 function makeNoMethodSetStateRule(methodName, shouldCheckUnsafeCb) {
   return {
     meta: {
       docs: {
         description: `Prevent usage of setState in ${methodName}`,
         category: 'Best Practices',
         recommended: false,
-        url: docsUrl(methodName)
+        url: docsUrl(mapTitle(methodName))
       },
 
       schema: [{