[Fix] Detect JSX returned by sequential expression (tests)

jsx-eslint · Sep 20, 2020 · 866f20e · 866f20e
1 parent 4dc6752
commit 866f20e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -71,7 +71,7 @@ function isReturnsLogicalJSX(node, property, strict) {
     : (returnsLogicalJSXLeft || returnsLogicalJSXRight);
 }
 
-function isReturnsSequentialJSX(node, property, strict) {
+function isReturnsSequentialJSX(node, property) {
   return node[property]
     && node[property].type === 'SequenceExpression'
     && jsxUtil.isJSX(node[property].expressions[node[property].expressions.length - 1]);
@@ -463,7 +463,7 @@ function componentRule(rule, context) {
 
       const returnsConditionalJSX = isReturnsConditionalJSX(node, property, strict);
       const returnsLogicalJSX = isReturnsLogicalJSX(node, property, strict);
-      const returnsSequentialJSX = isReturnsSequentialJSX(node, property, strict);
+      const returnsSequentialJSX = isReturnsSequentialJSX(node, property);
 
       const returnsJSX = node[property] && jsxUtil.isJSX(node[property]);
       const returnsPragmaCreateElement = this.isCreateElement(node[property]);

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2501,6 +2501,20 @@ ruleTester.run('prop-types', rule, {
       export default function() {}
       `
     },
+    {
+      code: `
+        function Component(props) {
+          return 0,
+          <div>
+            Hello, { props.name }!
+          </div>
+        }
+
+        Component.propTypes = {
+          name: PropTypes.string.isRequired
+        }
+      `
+    },
     parsers.TS([
       {
         code: `
@@ -5591,6 +5605,19 @@ ruleTester.run('prop-types', rule, {
         message: '\'foo.baz\' is missing in props validation'
       }]
     },
+    {
+      code: `
+        function Component(props) {
+          return 0,
+          <div>
+            Hello, { props.name }!
+          </div>
+        }
+      `,
+      errors: [{
+        message: '\'name\' is missing in props validation'
+      }]
+    },
     parsers.TS([
       {
         code: `