Move a function to jsxUtils

jsx-eslint · Sep 7, 2019 · 973b027 · 973b027
1 parent ffe97ce
commit 973b027
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/lib/rules/jsx-no-useless-fragment.js b/lib/rules/jsx-no-useless-fragment.js
@@ -60,12 +60,7 @@ function trimLikeReact(text) {
 function isKeyedElement(node) {
   return node.type === 'JSXElement' &&
     node.openingElement.attributes &&
-    node.openingElement.attributes.some(attribute => (
-      attribute.type === 'JSXAttribute' &&
-      attribute.name &&
-      attribute.name.type === 'JSXIdentifier' &&
-      attribute.name.name === 'key'
-    ));
+    node.openingElement.attributes.some(jsxUtil.isJSXAttributeKey);
 }
 
 module.exports = {

diff --git a/lib/util/jsx.js b/lib/util/jsx.js
@@ -64,8 +64,20 @@ function isJSX(node) {
   return node && ['JSXElement', 'JSXFragment'].indexOf(node.type) >= 0;
 }
 
+/**
+ * Check if node is like `key={...}` as in `<Foo key={...} />`
+ * @param {ASTNode} node
+ */
+function isJSXAttributeKey(node) {
+  return node.type === 'JSXAttribute' &&
+    node.name &&
+    node.name.type === 'JSXIdentifier' &&
+    node.name.name === 'key';
+}
+
 module.exports = {
   isDOMComponent,
   isFragment,
-  isJSX
+  isJSX,
+  isJSXAttributeKey
 };