resolve previous commit

jsx-eslint · Aug 5, 2022 · 9b595b9 · 9b595b9
1 parent 0bf8373
commit 9b595b9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js
@@ -103,7 +103,7 @@ function hasSecureRel(node, allowReferrer, warnOnSpreadAttributes, spreadAttribu
 
   const relAttribute = node.attributes[relIndex];
   const value = getStringFromValue(relAttribute.value);
-  return [].concat(value).filter(Boolean).some((item) => {
+  return [].concat(value).filter(Boolean).every((item) => {
     const tags = typeof item === 'string' && item.toLowerCase().split(' ');
     const noreferrer = tags && tags.indexOf('noreferrer') >= 0;
     const noopener = tags && tags.indexOf('noopener') >= 0;

diff --git a/tests/lib/rules/jsx-no-target-blank.js b/tests/lib/rules/jsx-no-target-blank.js
@@ -390,5 +390,14 @@ ruleTester.run('jsx-no-target-blank', rule, {
       code: '<a href={href} target="_blank" rel={isExternal ? 3 : "noopener noreferrer"} />',
       errors: defaultErrors,
     },
+    {
+      code: '<a href={href} target="_blank" rel={isExternal ? "noopener noreferrer" : "3"} />',
+      errors: defaultErrors,
+    },
+    {
+      code: '<a href={href} target="_blank" rel={isExternal ? "noopener" : "2"} />',
+      options: [{ allowReferrer: true }],
+      errors: allowReferrerErrors,
+    },
   ]),
 });