[Fix]: add more tests, use indexOf instead of includes

jsx-eslint · Aug 25, 2021 · a315a2f · a315a2f
1 parent ea30053
commit a315a2f
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/lib/util/propTypes.js b/lib/util/propTypes.js
@@ -925,7 +925,7 @@ module.exports = function propTypesInstructions(context, components, utils) {
 
       const typeName = context.getSourceCode().getText(annotation.typeName).replace(/ /g, '');
 
-      if (!allowedGenericTypes.includes(typeName)) return;
+      if (allowedGenericTypes.indexOf(typeName) === -1) return;
 
       markPropTypesAsDeclared(node, resolveTypeAnnotation(siblingIdentifier));
     } else {

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -6670,6 +6670,42 @@ ruleTester.run('prop-types', rule, {
           }
         ],
         parser: parsers['@TYPESCRIPT_ESLINT']
+      },
+      {
+        code: `
+          import React from 'react';
+          interface PersonProps {
+              test: string;
+          }
+          const Person: React.FunctionComponent<PersonProps> = (props): React.ReactElement => (
+              <div>{props.username}</div>
+          );
+        `,
+        errors: [
+          {
+            messageId: 'missingPropType',
+            data: {name: 'username'}
+          }
+        ],
+        parser: parsers['@TYPESCRIPT_ESLINT']
+      },
+      {
+        code: `
+          import React from 'react';
+          interface PersonProps {
+              username: string;
+          }
+          const Person: React.FunctionComponent<PersonProps> = (props): React.ReactElement => (
+              <div>{props.test}</div>
+          );
+        `,
+        errors: [
+          {
+            messageId: 'missingPropType',
+            data: {name: 'test'}
+          }
+        ],
+        parser: parsers['@TYPESCRIPT_ESLINT']
       }
     ])
   )