case #1334 - false negative with namespacing/qualifications using jsx…

…-pascal case #1336 - false postive with names starting with a number using jsx-pascal [Can besaid it is fixed, but inside it is not accepted anyway. Seems just fixed the regex]
jsx-eslint · Jul 31, 2017 · b14d73c · b14d73c
1 parent a19eec6
commit b14d73c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/rules/jsx-pascal-case.js b/lib/rules/jsx-pascal-case.js
@@ -11,7 +11,7 @@ const elementType = require('jsx-ast-utils/elementType');
 // Constants
 // ------------------------------------------------------------------------------
 
-const PASCAL_CASE_REGEX = /^([A-Z0-9]|[A-Z0-9]+[a-z0-9]+(?:[A-Z0-9]+[a-z0-9]*)*)$/;
+const PASCAL_CASE_REGEX = /^(.*[.])*([A-Z]|[A-Z]+[a-z0-9]+(?:[A-Z0-9]+[a-z0-9]*)*)$/;
 const COMPAT_TAG_REGEX = /^[a-z]|\-/;
 const ALL_CAPS_TAG_REGEX = /^[A-Z0-9]+$/;
 

diff --git a/tests/lib/rules/jsx-pascal-case.js b/tests/lib/rules/jsx-pascal-case.js
@@ -51,6 +51,8 @@ ruleTester.run('jsx-pascal-case', rule, {
     options: [{allowAllCaps: true}]
   }, {
     code: '<Modal.Header />'
+  }, {
+    code: '<qualification.T3stComp0nent />'
   }, {
     code: '<Modal:Header />'
   }, {