Make "NeedsMoreChidren" case fixable

jsx-eslint · May 18, 2019 · cfbea9d · cfbea9d
1 parent 001488e
commit cfbea9d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/jsx-no-useless-fragment.js b/lib/rules/jsx-no-useless-fragment.js
@@ -141,7 +141,8 @@ module.exports = {
       if (hasLessThanTwoChildren(node)) {
         context.report({
           node,
-          messageId: 'NeedsMoreChidren'
+          messageId: 'NeedsMoreChidren',
+          fix: isSafeToFix(node) ? (fixer => fix(node, fixer)) : null
         });
       }
 

diff --git a/tests/lib/rules/jsx-no-useless-fragment.js b/tests/lib/rules/jsx-no-useless-fragment.js
@@ -60,16 +60,19 @@ ruleTester.run('jsx-no-uselses-fragment', rule, {
   invalid: [
     {
       code: '<></>',
+      output: null,
       errors: [{messageId: 'NeedsMoreChidren', type: 'JSXFragment'}],
       parser: parsers.BABEL_ESLINT
     },
     {
       code: '<>foo</>',
+      output: null,
       errors: [{messageId: 'NeedsMoreChidren'}],
       parser: parsers.BABEL_ESLINT
     },
     {
       code: '<><div/></>',
+      output: null,
       errors: [{messageId: 'NeedsMoreChidren'}],
       parser: parsers.BABEL_ESLINT
     },
@@ -104,8 +107,15 @@ ruleTester.run('jsx-no-uselses-fragment', rule, {
       errors: [{messageId: 'NeedsMoreChidren'}],
       parser: parsers.BABEL_ESLINT
     },
+    {
+      code: '<Eeee><>foo</></Eeee>',
+      output: '<Eeee>foo</Eeee>',
+      errors: [{messageId: 'NeedsMoreChidren'}],
+      parser: parsers.BABEL_ESLINT
+    },
     {
       code: '<div><>foo</></div>',
+      output: '<div>foo</div>',
       errors: [{messageId: 'NeedsMoreChidren'}, {messageId: 'ChildOfHtmlElement'}],
       parser: parsers.BABEL_ESLINT
     },