[Fix] prop-types: Fix false positive on computed member expression

Fixes #1259
jsx-eslint · Mar 16, 2019 · d3dc4c8 · d3dc4c8
1 parent 005070d
commit d3dc4c8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
@@ -295,7 +295,11 @@ module.exports = function usedPropTypesInstructions(context, components, utils)
         name = getPropertyName(node);
         if (name) {
           allNames = parentNames.concat(name);
-          if (node.parent.type === 'MemberExpression') {
+          if (
+            // Match props.foo.bar, don't match bar[props.foo]
+            node.parent.type === 'MemberExpression' &&
+            node.parent.object === node
+          ) {
             markPropTypesAsUsed(node.parent, allNames);
           }
           // Do not mark computed props as used.

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2303,6 +2303,19 @@ ruleTester.run('prop-types', rule, {
         const b = a::fn1();
       `,
       parser: 'babel-eslint'
+    },
+    {
+      // issue #1259
+      code: `
+        const Hello = props => {
+          const { notInProp } = dict[props.foo];
+          return <div />
+        }
+
+        Hello.propTypes = {
+          foo: PropTypes.number,
+        }
+      `
     }
   ],