Merge pull request #1669 from justinanastos/fix/sort-prop-types-shape…

…-no-properties-1668 fix(sort-prop-types): Fix sortShapeProp when shape is not an object literal
jsx-eslint · Jan 31, 2018 · d818f2b · d818f2b
2 parents cfd3959 + 17ac433
commit d818f2b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/lib/rules/sort-prop-types.js b/lib/rules/sort-prop-types.js
@@ -77,6 +77,12 @@ module.exports = {
      * @returns {void}
      */
     function checkSorted(declarations) {
+      // Declarations will be `undefined` if the `shape` is not a literal. For
+      // example, if it is a propType imported from another file.
+      if (!declarations) {
+        return;
+      }
+
       declarations.reduce((prev, curr, idx, decls) => {
         if (/SpreadProperty$/.test(curr.type)) {
           return decls[idx + 1];

diff --git a/tests/lib/rules/sort-prop-types.js b/tests/lib/rules/sort-prop-types.js
@@ -365,6 +365,24 @@ ruleTester.run('sort-prop-types', rule, {
     options: [{
       sortShapeProp: true
     }]
+  }, {
+    code: `
+      class Component extends React.Component {
+        render() {
+          return <div />;
+        }
+      }
+      Component.propTypes = {
+        a: PropTypes.any,
+        b: PropTypes.any,
+        c: PropTypes.shape(
+          importedPropType,
+        ),
+      };
+    `,
+    options: [{
+      sortShapeProp: true
+    }]
   }],
 
   invalid: [{