[Fix] sort-comp: correctly recognize instance variables declared wi…

…thout explicit value Fixes #2183
jsx-eslint · Mar 5, 2019 · e1a5889 · e1a5889
1 parent 4a72e6a
commit e1a5889
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/lib/rules/sort-comp.js b/lib/rules/sort-comp.js
@@ -392,8 +392,7 @@ module.exports = {
         static: node.static,
         instanceVariable: !node.static &&
           node.type === 'ClassProperty' &&
-          node.value &&
-          !astUtil.isFunctionLikeExpression(node.value),
+          (!node.value || !astUtil.isFunctionLikeExpression(node.value)),
         instanceMethod: !node.static &&
           node.type === 'ClassProperty' &&
           node.value &&

diff --git a/tests/lib/rules/sort-comp.js b/tests/lib/rules/sort-comp.js
@@ -480,6 +480,29 @@ ruleTester.run('sort-comp', rule, {
       '  static getDerivedStateFromProps() {}',
       '}'
     ].join('\n')
+  }, {
+    code: `
+      class MyComponent extends React.Component {
+        state = {};
+        foo;
+        static propTypes;
+
+        render() {
+          return null;
+        }
+      }
+    `,
+    parser: 'babel-eslint',
+    options: [{
+      order: [
+        'state',
+        'instance-variables',
+        'static-methods',
+        'lifecycle',
+        'render',
+        'everything-else'
+      ]
+    }]
   }],
 
   invalid: [{