[Fix] display-name: avoid crash on for..of

Fixes #2137.
jsx-eslint · Jan 17, 2019 · e635964 · e635964
1 parent 433cc3f
commit e635964
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -567,7 +567,12 @@ function componentRule(rule, context) {
         }
         if (refId.type === 'MemberExpression') {
           componentNode = refId.parent.right;
-        } else if (refId.parent && refId.parent.type === 'VariableDeclarator' && refId.parent.init.type !== 'Identifier') {
+        } else if (
+          refId.parent
+          && refId.parent.type === 'VariableDeclarator'
+          && refId.parent.init
+          && refId.parent.init.type !== 'Identifier'
+        ) {
           componentNode = refId.parent.init;
         }
         break;

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -452,6 +452,17 @@ ruleTester.run('display-name', rule, {
 
       export default React.memo(Component)
     `
+  }, {
+    code: `
+      function F() {
+        let items = [];
+        let testData = [{a: "test1", displayName: "test2"}, {a: "test1", displayName: "test2"}];
+        for (let item of testData) {
+            items.push({a: item.a, b: item.displayName});
+        }
+        return <div>{items}</div>;
+      }
+    `
   }],
 
   invalid: [{