Merge pull request #2238 from pawelnvk/pure-function-validation

[Fix] `prefer-stateless-function`: Ignoring pure components without props and context usage
jsx-eslint · Apr 12, 2019 · f0c0b4d · f0c0b4d
2 parents 157332f + bedba5d
commit f0c0b4d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/docs/rules/prefer-stateless-function.md b/docs/rules/prefer-stateless-function.md
@@ -66,22 +66,18 @@ class Foo extends React.Component {
 
 When `true` the rule will ignore Components extending from `React.PureComponent` that use `this.props` or `this.context`.
 
-The following pattern is considered okay and does **not** cause warnings:
+The following patterns are considered okay and does **not** cause warnings:
 
 ```jsx
 class Foo extends React.PureComponent {
   render() {
     return <div>{this.props.foo}</div>;
   }
 }
-```
-
-The following pattern is considered a warning because it's not using props or context:
 
-```jsx
-class Foo extends React.PureComponent {
+class Bar extends React.PureComponent {
   render() {
-    return <div>Bar</div>;
+    return <div>Baz</div>;
   }
 }
 ```
diff --git a/lib/rules/prefer-stateless-function.js b/lib/rules/prefer-stateless-function.js
@@ -369,7 +369,7 @@ module.exports = {
             return;
           }
 
-          if (list[component].hasSCU && list[component].usePropsOrContext) {
+          if (list[component].hasSCU) {
             return;
           }
           context.report({

diff --git a/tests/lib/rules/prefer-stateless-function.js b/tests/lib/rules/prefer-stateless-function.js
@@ -304,6 +304,18 @@ ruleTester.run('prefer-stateless-function', rule, {
         }
       `,
       parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class Child extends PureComponent {
+          render() {
+            return <h1>I don't</h1>;
+          }
+        }
+      `,
+      options: [{
+        ignorePureComponents: true
+      }]
     }
   ],
 
@@ -339,9 +351,6 @@ ruleTester.run('prefer-stateless-function', rule, {
           }
         }
       `,
-      options: [{
-        ignorePureComponents: true
-      }],
       errors: [{
         message: 'Component should be written as a pure function'
       }]