Forbid forbidden function argument #2662

jsx-eslint · Jun 16, 2020 · fcae315 · fcae315
1 parent 08cdd39
commit fcae315
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
@@ -59,6 +59,15 @@ module.exports = {
       return forbid.indexOf(type) >= 0;
     }
 
+    function reportIfForbidden(type, declaration, target) {
+      if (isForbidden(type)) {
+        context.report({
+          node: declaration,
+          message: `Prop type \`${target}\` is forbidden`
+        });
+      }
+    }
+
     function shouldCheckContextTypes(node) {
       if (checkContextTypes && propsUtil.isContextTypesDeclaration(node)) {
         return true;
@@ -94,19 +103,17 @@ module.exports = {
           value = value.object;
         }
         if (value.type === 'CallExpression') {
+          value.arguments.forEach((arg) => {
+            reportIfForbidden(arg.name, declaration, target);
+          });
           value = value.callee;
         }
         if (value.property) {
           target = value.property.name;
         } else if (value.type === 'Identifier') {
           target = value.name;
         }
-        if (isForbidden(target)) {
-          context.report({
-            node: declaration,
-            message: `Prop type \`${target}\` is forbidden`
-          });
-        }
+        reportIfForbidden(target, declaration, target);
       });
     }
 

diff --git a/test/mocha.opts b/test/mocha.opts
@@ -1 +0,0 @@
---reporter=min