react/no-this-in-sfc: eslint-plugin-react 7.25.0 interprets an old legacy jQuery plugin as a sfc

[doberkofler]

I get lot's of false positive react/no-this-in-sfc warnings in Typescript (*.ts) Files.
It seems as if TypeScript files with ts (not just tsx) extension would be regarded as react files and of type $.fn.<lowercase>... = function (): <type> | null would be interpreted as an sfc:

$.fn.getValueAsStringWeak = function (): string | null {
	const val = this.length === 1 ? this.val() : null;

	return typeof val === 'string' ? val : null;
};

[ljharb]

Does this not happen in v7.24.0?

[doberkofler]

Does this not happen in v7.24.0?

Yes, it does this not happen in v7.24.0

[ljharb]

I’d expect this to not be identified as a component since it’s not a PascalCase-named function.

[ljharb]

Using git bisect, this appears to have been introduced by 9a8a4b5 / #2992 / @Wesitos.

[Wesitos]

I found this equivalent false positive. I'm debugging this. Not sure how it broke.

obj.notAComponent = function () {
  return this.a || null;
};`

[ljharb]

I’ve got a local test case as well i can tack on if you make a PR :-)

[Wesitos]

I just noticed that I also modified getStatelessComponent. Well... that explains it :b.