Fix handling of identifiers #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes incorrect behavior when propTypes were stored in a variable and then referenced later. jsx-eslint#1352
dustinsoftware
force-pushed
the
issue1352
branch
from
ab769b4
to
69e5201
Compare
dustinsoftware
changed the title
ljharb
approved these changes
Aug 11, 2017
| @@ -565,6 +565,42 @@ ruleTester.run('sort-prop-types', rule, { | |||
| }] | |||
| }, { | |||
| code: [ | |||
| 'const First = (props) => <div />;', | |||
| 'const propTypes = {', | |||
There was a problem hiding this comment.
can you also (just in case) add a test with export const propTypes = … to this rule too?
There was a problem hiding this comment.
Sure, just so I can understand, what behavior will that change be verifying?
There was a problem hiding this comment.
Hopefully nothing; I'm just making sure that an export declaration works just as well as a variable declaration :-)
| 'export const propTypes = {a: PropTypes.any};', | ||
| 'export default function Component() {}', | ||
| 'Component.propTypes = forbidExtraProps(propTypes);' | ||
| ].join('\n'), | ||
| // errors: [{message: ANY_ERROR_MESSAGE}], // TODO: make this pass |
yannickcr
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352