[jsx-no-target-blank] Allow either noopener or noreferrer #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the HTML5 Standard spec: > `<a href="..." rel="noreferrer" target="_blank">` > has the same behavior as > `<a href="..." rel="noreferrer noopener" target="_blank”>` https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer
ljharb
requested changes
Aug 23, 2017
There was a problem hiding this comment.
The discussion at GoogleChrome/lighthouse#2485 is still unresolved; personally, I prefer the explicitness of requiring both.
Prior to the outcome of that discussion, I'd want the default to be "both", and a configurable option to allow "only noreferrer".
It is now: GoogleChrome/lighthouse#2485 (comment) |
|
Closing PR as it's already done #2043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
noreferrerfor my external links which also disableswindow.opener, but the rule insists on requiringnoopenereven though it's redundant.According to the HTML5 Standard spec:
Also fixes #776
See also GoogleChrome/lighthouse#2482 and GoogleChrome/lighthouse#2485