Fix failures of jsx-max-depth on empty nodes

[j-martyn]

On some my code (didn't check what code exactly) I got this:

Cannot read property 'type' of null
TypeError: Cannot read property 'type' of null
    at find (/path/to/package/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:93:27)
    at findJSXElement (/path/to/package/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:102:49)
    at JSXExpressionContainer (/path/to/package/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:137:25)

So, for now, I just have fixed it. No tests have been changed as I didn't investigate it.

[ljharb]

Thanks for the fix!

It's pretty important to find the code this broke on, so that we can add a regression test.

[ljharb]

probably this whole chain should be rewritten for clarity; at the least, let's use parens so as to not mix && and || :-)

[ferhatelmas]

@j-martyn @ljharb Any ETA ? I see this crash too.

FYI, it happens on files with jsx-control-statements.

[ljharb]

@ferhatelmas if you could provide a failing test case (on a branch in your fork), and link it here, i'll add it to the PR and we can get this in.

[ljharb]

cc @alexzherdev if you're interested in taking a look at this one, i'm happy to add any commits you like to this PR branch :-) (cc #1824)

[alexzherdev]

I'll see if I can reproduce this 👍

[ljharb]

ping @alexzherdev, any progress?