Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support proptype shape in a variable for sortShapeProp #1823

Merged
merged 1 commit into from May 20, 2019
Merged

Support proptype shape in a variable for sortShapeProp #1823

merged 1 commit into from May 20, 2019

Conversation

alexzherdev
Copy link
Contributor

Resolves #1749

ljharb
ljharb approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

lib/rules/sort-prop-types.js Outdated Show resolved Hide resolved
@alexzherdev
Copy link
Contributor Author

Rebased and added test outputs for the fixer that was added recently.

@ljharb ljharb merged commit a3c6d7e into jsx-eslint:master May 20, 2019
@alexzherdev alexzherdev deleted the 1749-shape-variable branch May 20, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@EvHaus EvHaus EvHaus approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

@lencioni lencioni Awaiting requested review from lencioni

Assignees
No one assigned
Labels
enhancement rule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sort-prop-types throws an error with a shape defined by a const
3 participants
@alexzherdev @ljharb @EvHaus