Account for UNSAFE_ method in no-will-update-set-state #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzherdev
force-pushed
the
1844-no-set-state-unsafe-will-update
branch
from
3cb8d0d
to
40c4ffa
Compare
ljharb
reviewed
Jun 24, 2018
lib/util/makeNoMethodSetStateRule.js
Outdated
| @@ -28,6 +28,15 @@ function makeNoMethodSetStateRule(methodName) { | |||
| create: function(context) { | |||
| const mode = context.options[0] || 'allow-in-func'; | |||
|
|
|||
| function nameMatches(name) { | |||
| let matches = name === methodName; | |||
There was a problem hiding this comment.
This seems like it could return immediately if true, cleaning up the rest of the function
ljharb
force-pushed
the
1844-no-set-state-unsafe-will-update
branch
from
40c4ffa
to
8122c8b
Compare
ljharb
approved these changes
Jun 24, 2018
|
Ah, thanks! |
calebeby
pushed a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 30, 2018
This Pull Request updates dependency [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from `v7.9.1` to `v7.10.0` <details> <summary>Release Notes</summary> ### [`v7.10.0`](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md#​7100---2018-06-24) [Compare Source](jsx-eslint/eslint-plugin-react@v7.9.1...v7.10.0) ##### Added * Allow eslint ^5 ([#​1843][] @​papandreou, @​ljharb) * [`no-unsafe`][] rule ([#​1831][], [#​1830][] @​sergei-startsev) * [`no-will-update-set-state`][]: Account for `UNSAFE_` methods ([#​1845][], [#​1844][] @​alexzherdev) ##### Fixed * [`no-typos`][]: Fix static propTypes handling ([#​1827][], [#​1677][] @​alexzherdev) * [`destructuring-assignment`][]: Allow LHS ([#​1825][], [#​1728][] @​alexzherdev) * [`no-unused-prop-types`][]: Fix crash when encountering mixed union and intersection flow types ([#​1806][] @​yannickcr) ##### Changed * Typo fixes in [`jsx-no-target-blank`][] ([#​1805][] @​ferhatelmas)) [#​1845]: `jsx-eslint/eslint-plugin-react#1845 [#​1844]: `jsx-eslint/eslint-plugin-react#1844 [#​1843]: `jsx-eslint/eslint-plugin-react#1843 [#​1831]: `jsx-eslint/eslint-plugin-react#1831 [#​1830]: `jsx-eslint/eslint-plugin-react#1830 [#​1827]: `jsx-eslint/eslint-plugin-react#1827 [#​1825]: `jsx-eslint/eslint-plugin-react#1825 [#​1806]: `jsx-eslint/eslint-plugin-react#1806 [#​1805]: `jsx-eslint/eslint-plugin-react#1805 [#​1728]: `jsx-eslint/eslint-plugin-react#1728 [#​1677]: `jsx-eslint/eslint-plugin-react#1677 --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Sep 22, 2018
Closed
This was referenced Sep 23, 2018
Open
Open
Open
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1844