Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reservedFirst for jsx-sort-props rule #1883

Merged
merged 2 commits into from Jul 16, 2018
Merged

Fix reservedFirst for jsx-sort-props rule #1883

merged 2 commits into from Jul 16, 2018

Commits on Jul 13, 2018

  1. [jsx-sort-props] Test reservedFirst/shorthandLast 

    Add tests, that surface the incorrect behavior of the combinations
`reservedFirst` and `shorthandLast` for the `jsx-sort-props` rule.
    @fleischie
    fleischie committed Jul 13, 2018
    Copy the full SHA
    049d95e View commit details
    Browse the repository at this point in the history

  2. [jsx-sort-props] Fix rule's behavior 

    - Remove unneccessary handling of sort-checking in jsx props, as this is
  being handled later by the general case anyways.
- Fix erroneous call to `generateFixerFunction` in general
  sort-checking, which was missing the `reservedList` parameter.
    @fleischie
    fleischie committed Jul 13, 2018
    Copy the full SHA
    21faf02 View commit details
    Browse the repository at this point in the history