Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state-in-constructor rule #1945

Merged
merged 9 commits into from Jan 21, 2019

Commits on Aug 18, 2018

  1. Init rule state-in-constructor

    lukyth committed Aug 18, 2018
    Copy the full SHA
    a312b16 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    2f06677 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4706e86 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2018

  1. Remove test cases for always option in state-in-constructor rule

    Since `always` is the default option, we can use the no-option cases to
    cover these `always` cases.
    
    I left one `always` case to make sure that having an option as `always`
    will act the same way as no-option.
    lukyth committed Aug 19, 2018
    Copy the full SHA
    81d0e8b View commit details
    Browse the repository at this point in the history
  2. Fix a case where AssignmentExpression is deeply nested

    This commit also refactor `inConstructor` function from `prop-types`
    rule into `utils/Components` so that another rule could use that logic
    as well.
    lukyth committed Aug 19, 2018
    Copy the full SHA
    3516a81 View commit details
    Browse the repository at this point in the history
  3. Fix a case where left side of assignment is not MemberExpression

    This commit also move `isStateMemberExpression` from
    `no-direct-mutation-state` rule into `util/Components` so that the logic
    could be share with other rules.
    lukyth committed Aug 19, 2018
    Copy the full SHA
    b1024c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. Copy the full SHA
    b0e4c84 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Copy the full SHA
    acc35a1 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    9415814 View commit details
    Browse the repository at this point in the history