Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full example in react/jsx-no-target-blank #1988

Merged
merged 3 commits into from Sep 20, 2018
Merged

Add full example in react/jsx-no-target-blank #1988

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eae31a0
add example of complete react/jsx-no-target-blank rule
tom-nexudus Sep 18, 2018
658379a
undid editor prettifying opinions
tom-nexudus Sep 18, 2018
ac78b51
quotes for json key, reordered information
atomcorp Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion docs/rules/jsx-no-target-blank.md
View file
Open in desktop
Expand Up @@ -18,6 +18,13 @@ There are two main options for the rule:
* `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default)
* `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link

```json
"react/jsx-no-target-blank": [<enabled>, { enforceDynamicLinks: <enforce> }]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key needs to be quoted, since it's json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

```

* enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0.
ljharb marked this conversation as resolved.
Show resolved Hide resolved
* enforce: optional string, defaults to "always"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems redundant, since it's on lines 18-19

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I'm following how it works on some other pages



### always (default)

Expand Down Expand Up @@ -48,4 +55,4 @@ var Hello = <a target='_blank' href={ dynamicLink }></a>

## When Not To Use It

If you do not have any external links, you can disable this rule
If you do not have any external links, you can disable this rule