New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change allowed propWrapperFunctions setting values #2065
Merged
ljharb
merged 1 commit into
jsx-eslint:master
from
jomasti:feature/prop-wrapper-functions-schema-change
Dec 3, 2018
Merged
Change allowed propWrapperFunctions setting values #2065
ljharb
merged 1 commit into
jsx-eslint:master
from
jomasti:feature/prop-wrapper-functions-schema-change
Dec 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is adapting the `propWrapperFunctions` setting to allow for using objects along side the already present strings. This will help facilitate adding extra attributes to these objects like for exact prop functions. Precursor to jsx-eslint#1547.
ljharb
reviewed
Dec 2, 2018
ljharb
approved these changes
Dec 3, 2018
ljharb
force-pushed
the
feature/prop-wrapper-functions-schema-change
branch
from
December 3, 2018 07:36
f80d956
to
a33bfb1
Compare
1 task
1 task
This was referenced Dec 28, 2018
Closed
This was referenced Jan 4, 2019
Closed
Closed
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is adapting the
propWrapperFunctions
setting to allow forusing objects along side the already present strings. This will help
facilitate adding extra attributes to these objects like for exact prop
functions.
This was initially proposed here.