Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no-array-index-key not working in React.Children methods #2085

Merged
merged 5 commits into from Dec 22, 2018
Merged

Fix: no-array-index-key not working in React.Children methods #2085

merged 5 commits into from Dec 22, 2018

Commits on Dec 13, 2018

  1. 🔧 Fix for usage of React.Children methods 

    Fixes the case where you are iterating over a children prop via the
React.Children API.
    @himynameisdave
    himynameisdave committed Dec 13, 2018
    Copy the full SHA
    925450f View commit details
    Browse the repository at this point in the history

  2. 🔬 Adds unit test coverage for new use cases

    @himynameisdave
    himynameisdave committed Dec 13, 2018
    Copy the full SHA
    cb425c3 View commit details
    Browse the repository at this point in the history

  3. 📖 Adds warning cases to rule documentation

    @himynameisdave
    himynameisdave committed Dec 13, 2018
    Copy the full SHA
    9253c10 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. Merge branch 'master' of https://github.com/yannickcr/eslint-plugin-r… 

    …eact into issues/2083
    @himynameisdave
    himynameisdave committed Dec 20, 2018
    Copy the full SHA
    f7e3121 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. 📝 Addresses CR comments 

    - Uses pragma context instead of 'React'
- Adds back spaces I removed which increase readability
    @himynameisdave
    himynameisdave committed Dec 21, 2018
    Copy the full SHA
    8be52c7 View commit details
    Browse the repository at this point in the history