Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-curly-brace-presence: accept multiline template string #2203

Merged
merged 1 commit into from Mar 18, 2019
Merged

[Fix] jsx-curly-brace-presence: accept multiline template string #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rules/jsx-curly-brace-presence.js 100644 → 100755
View file
Open in desktop
Expand Up @@ -182,6 +182,7 @@ module.exports = {
} else if (
expressionType === 'TemplateLiteral' &&
expression.expressions.length === 0 &&
expression.quasis[0].value.raw.indexOf('\n') === -1 &&
!needToEscapeCharacterForJSX(expression.quasis[0].value.raw) && (
jsxUtil.isJSX(JSXExpressionNode.parent) ||
!containsQuoteCharacters(expression.quasis[0].value.cooked)
Expand Down
38 changes: 38 additions & 0 deletions tests/lib/rules/jsx-curly-brace-presence.js 100644 → 100755
View file
Open in desktop
Expand Up @@ -241,6 +241,44 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
{
code: ['<a a={"start\\', '\\', 'end"}/>'].join('/n'),
options: ['never']
},
{
code: `
<App prop={\`
a
b
\`} />
`,
options: ['never']
ljharb marked this conversation as resolved.
Show resolved Hide resolved
},
{
code: `
<App prop={\`
a
b
\`} />
`,
options: ['always']
},
{
code: `
<App>
{\`
a
b
\`}
</App>
`,
options: ['never']
},
{
code: `
<App>{\`
a
b
\`}</App>
`,
options: ['always']
}
],

Expand Down