Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] prop-types: fix crash on multiple destructuring #2320

Merged
merged 1 commit into from Jun 24, 2019
Merged

[Fix] prop-types: fix crash on multiple destructuring #2320

merged 1 commit into from Jun 24, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Jun 24, 2019

fixes #2319

@dsifford
Copy link

Just confirming that this fix resolves the issue for me. 👍

@ljharb ljharb added the bug label Jun 24, 2019
@ljharb ljharb merged commit 655eb01 into jsx-eslint:master Jun 24, 2019
@golopot golopot deleted the issue-2319 branch June 24, 2019 03:54
@yoyo837
Copy link
Contributor

yoyo837 commented Jun 24, 2019

same issue with v7.14.0

const {
  data: { declareCurrentNode },
} = this.props;
const { nodeAuditType } = declareCurrentNode;

@golopot
Copy link
Contributor Author

golopot commented Jun 24, 2019

@yoyo837 That case is covered by this pr.

@yoyo837
Copy link
Contributor

yoyo837 commented Jun 24, 2019

But still report: 'VariableDeclarator ASTNodes are not handled by markPropTypesAsUsed'

@golopot
Copy link
Contributor Author

golopot commented Jun 24, 2019

This fix is not released yet. The bug will still be present on 7.14.0.

@yoyo837
Copy link
Contributor

yoyo837 commented Jun 24, 2019

I thought 7.14.0 has fixed it. Thanks.

@yannickcr
Copy link
Member

Thanks for the fix @golopot 👍 I just released v7.14.1 with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: VariableDeclarator ASTNodes are not handled by markPropTypesAsUsed
5 participants
@golopot @dsifford @yoyo837 @yannickcr @ljharb