Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2381-fix camelCase error in jsx-sort-props #2391

Merged
merged 1 commit into from Aug 31, 2019
Merged

2381-fix camelCase error in jsx-sort-props #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/jsx-sort-props.js
View file
Open in desktop
Expand Up @@ -342,7 +342,7 @@ module.exports = {
}
}

if (!noSortAlphabetically && currentPropName < previousPropName) {
if (!noSortAlphabetically && previousPropName.localeCompare(currentPropName) > 0) {
context.report({
node: decl.name,
message: 'Props should be sorted alphabetically',
Expand Down
36 changes: 30 additions & 6 deletions tests/lib/rules/jsx-sort-props.js
View file
Open in desktop
Expand Up @@ -109,7 +109,11 @@ ruleTester.run('jsx-sort-props', rule, {
{code: '<App a="c" b="b" c="a" />;'},
{code: '<App {...this.props} a="c" b="b" c="a" />;'},
{code: '<App c="a" {...this.props} a="c" b="b" />;'},
{code: '<App A a />;'},
{code: '<App a A />;'},
{code: '<App aa aB />;'},
{code: '<App aA aB />;'},
{code: '<App aaa aB />;'},
{code: '<App a aa aB />;'},
// Ignoring case
{code: '<App a A />;', options: ignoreCaseArgs},
{code: '<App a B c />;', options: ignoreCaseArgs},
Expand Down Expand Up @@ -165,6 +169,31 @@ ruleTester.run('jsx-sort-props', rule, {
errors: [expectedError],
output: '<App a b />;'
},
{
code: '<App aB a />;',
errors: [expectedError],
output: '<App a aB />;'
},
{
code: '<App A a />;',
errors: [expectedError],
output: '<App a A />;'
},
{
code: '<App aB aA />;',
errors: [expectedError],
output: '<App aA aB />;'
},
{
code: '<App aaB aA />;',
errors: [expectedError],
output: '<App aA aaB />;'
},
{
code: '<App aaB aaa aA a />;',
errors: [expectedError, expectedError, expectedError],
output: '<App a aA aaa aaB />;'
},
{
code: '<App {...this.props} b a />;',
errors: [expectedError],
Expand All @@ -175,11 +204,6 @@ ruleTester.run('jsx-sort-props', rule, {
errors: [expectedError],
output: '<App c {...this.props} a b />;'
},
{
code: '<App a A />;',
errors: [expectedError],
output: '<App a A />;'
},
{
code: '<App B a />;',
options: ignoreCaseArgs,
Expand Down