New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edge cases on jsx-pascal-case #2637
Draft
yacinehmito
wants to merge
5
commits into
jsx-eslint:master
Choose a base branch
from
yacinehmito:fix-1334
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no fix yet. I am waiting for #2636 to be merged. |
@yacinehmito are you interested in completing this PR? |
ljharb
force-pushed
the
master
branch
6 times, most recently
from
November 11, 2022 02:45
59af733
to
865ed16
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
November 18, 2022 06:58
6217370
to
069314a
Compare
I am sorry, I lost interest as I was not using React anymore. |
@yacinehmito i'd still prefer to leave it open so someone else can finish it, if that's ok :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rule
jsx-pascal-case
doesn't support some edge cases:The PR should fix #1334