[New]jsx-key: add check for unique key
#2701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jul 7, 2020
Comment on lines
+64
to
+66
| ### `checkUniquePropKey` (default: `true`) | ||
|
|
||
| When `false` the validation for unique `key` in array literal and sibling JSX elements is disabled. |
There was a problem hiding this comment.
to avoid a breaking change, this also needs to default to false, just like checkFragmentShorthand.
There was a problem hiding this comment.
(i can see an argument for it not being enabled by default, but i don't think it's worth the risk)
| const reactPragma = pragmaUtil.getFromContext(context); | ||
| const fragmentPragma = pragmaUtil.getFragmentFromContext(context); | ||
| const processedNodes = new Set(); |
There was a problem hiding this comment.
Suggested change
| const processedNodes = new Set(); | |
| const processedNodes = new WeakSet(); |
| if (hasProp(node.openingElement.attributes, 'key')) { | ||
| return; | ||
| } | ||
| function nodeProcessed(node) { |
There was a problem hiding this comment.
this reads like it's a predicate, but it also has the side effect of marking the node as processed. maybe it needs a better name?
There was a problem hiding this comment.
Yeah, you are right. 🤔 What do you think about checkAndMarkNodeProcessed? I am not crazy about this one but at least express better the behavior.
jzabala
force-pushed
the
feat/jsx-key-check-uniqueness
branch
from
a1538c7
to
6cc9a00
Compare
jzabala
changed the title
jsx-key: add check for unique key
|
Please mark this PR as ready for review once it is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
keyuniqueness check in array literal and sibling JSX elements.Closes #2614