[New] jsx-max-props-per-line: add multi/single line config options
#2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 30, 2020
| @@ -32,22 +48,23 @@ ruleTester.run('jsx-max-props-per-line', rule, { | |||
| code: '<App foo />' | |||
| }, { | |||
| code: '<App foo bar />', | |||
| options: [{maximum: 2}] | |||
| options: [getConfigs(2)] | |||
There was a problem hiding this comment.
i'm not convinced this is clearer than just repeating each configuration inline. It's much harder for me to evaluate the test cases this way. Can you update this to remove getConfigs?
lib/rules/jsx-max-props-per-line.js
Outdated
| type: 'integer', | ||
| minimum: 1 | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| }, | |
| "additionalProperties": false |
(if i'm remembering the syntax right)
lib/rules/jsx-max-props-per-line.js
Outdated
Comment on lines
26
to
28
| maximum: { | ||
| type: 'integer', | ||
| minimum: 1 | ||
| type: 'object', | ||
| properties: { |
There was a problem hiding this comment.
this is a breaking change unless it uses anyOf or oneOf to allow both an integer and an object.
ljharb
changed the title
jsx-max-props-per-line: add multi/single line config options
|
Is anyone working on this? Can I take a shot at it? |
|
@dherault please go ahead. I'm a little busy with my office stuff. |
|
@dherault please do not open a new PR - please post a link here to a branch/commit, and I'll update this PR. |
|
Duplicate of #3078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2735