New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix handling of warnOnSpreadAttributes being false #2953
Conversation
… being false Fixes jsx-eslint#2952
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Codecov Report
@@ Coverage Diff @@
## master #2953 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 110 110
Lines 7256 7256
Branches 2643 2643
=======================================
Hits 7081 7081
Misses 175 175
Continue to review full report at Codecov.
|
I too was glad that it was such a simple fix. |
The behavior of this rule changed in jsx-eslint/eslint-plugin-react#2953 and we upgraded the plugin in #2172
The behavior of this rule changed in jsx-eslint/eslint-plugin-react#2953 and we upgraded the plugin in #2172
The behavior of this rule changed in jsx-eslint/eslint-plugin-react#2953 and we upgraded the plugin in adeira/universe#2172 adeira-source-id: 4bcc4b66f25ba51caccfba42be35f691e02a0c55
fixes #2952