Document #3008 adds a test to no-unused-prop-types #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to figure out why there's a false positive - adds easy way to keep investivating issue - No side effects
|
Nice, Great job! Would you please check if this is a case of SFC The example in the doc is using flow but the same should apply to TS. Ie if you try to use this prop not within a function would there still be an error? |
|
This is an SFC, but the place being warned on is a render prop - which isn't a component. |
ljharb
force-pushed
the
master
branch
6 times, most recently
from
59af733
to
865ed16
Compare
ljharb
force-pushed
the
master
branch
4 times, most recently
from
069314a
to
181c68f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3023 +/- ##
==========================================
- Coverage 97.58% 94.52% -3.06%
==========================================
Files 130 130
Lines 9218 9218
Branches 3341 3341
==========================================
- Hits 8995 8713 -282
- Misses 223 505 +282
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3008 request to add a test for maintainers
@DianaSuvorova