Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] jsx-pascal-case: add allowLeadingUnderscore option #3041

Merged
merged 1 commit into from Aug 12, 2021
Merged

[New] jsx-pascal-case: add allowLeadingUnderscore option #3041

merged 1 commit into from Aug 12, 2021

Conversation

mwaddell
Copy link
Contributor

@mwaddell mwaddell commented Aug 12, 2021

Fixes #2603
Replaces #3039

  • Adds a new optional allowLeadingUnderscore property to the existing jsx-pascal-case rule.
  • Updates documentation to clearly explain when not to use it
  • Updates unit tests to ensure coverage

@ljharb
Copy link
Member

ljharb commented Aug 12, 2021

I’ll keep both PRs in sync and land them together :-) thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #3041 (064afc2) into master (0894132) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
+ Coverage   97.38%   97.40%   +0.01%     
==========================================
  Files         111      111              
  Lines        7426     7428       +2     
  Branches     2713     2715       +2     
==========================================
+ Hits         7232     7235       +3     
+ Misses        194      193       -1     
Impacted Files Coverage Δ
lib/rules/jsx-pascal-case.js 100.00% <100.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0894132...064afc2. Read the comment docs.

@ljharb ljharb changed the title Add allowLeadingUnderscore option to existing jsx-pascal-case rule [New] jsx-pascal-case: add allowLeadingUnderscore option Aug 12, 2021
@ljharb ljharb merged commit e0c0812 into jsx-eslint:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

jsx-pascal-case: Allow leading underscore
3 participants