Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-key: catch key errors inside conditional statements #3320

Merged
merged 1 commit into from Jul 4, 2022
Merged

[Fix] jsx-key: catch key errors inside conditional statements #3320

merged 1 commit into from Jul 4, 2022

Conversation

TildaDares
Copy link
Contributor

Fixes #3117

@TildaDares
Copy link
Contributor Author

@ljharb Please review!

@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited

Codecov Report

Merging #3320 (757f0b5) into master (7a7bb99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 757f0b5 differs from pull request most recent head 1948765. Consider uploading reports for the commit 1948765 to get more accurate results

@@           Coverage Diff           @@
##           master    #3320   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         123      123           
  Lines        8766     8777   +11     
  Branches     3178     3184    +6     
=======================================
+ Hits         8565     8576   +11     
  Misses        201      201
Impacted Files Coverage Δ
lib/rules/jsx-key.js 97.70% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7bb99...1948765. Read the comment docs.

ljharb
ljharb approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lib/rules/jsx-key.js Outdated Show resolved Hide resolved
lib/rules/jsx-key.js Outdated Show resolved Hide resolved
@ljharb ljharb changed the title fix jsx-key bug - eslint not catching jsx-key error inside conditional statements [Fix] jsx-key: catch key errors inside conditional statements Jul 4, 2022
@ljharb ljharb merged commit 1948765 into jsx-eslint:master Jul 4, 2022
@TildaDares TildaDares deleted the jsx-key-bug branch July 5, 2022 05:26
ljharb added a commit to ljharb/eslint-plugin-react that referenced this pull request Jul 10, 2022
@ljharb
[Fix] jsx-key: avoid a crash from optional chaining from jsx-eslint…
4d19cd6 
…#3320

Fixes jsx-eslint#3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eslint does not work if the jsx key is missed inconditions
2 participants
@TildaDares @ljharb