Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] False negative when rel attribute assigned using ternary #3332

Merged
merged 1 commit into from Aug 12, 2022

Conversation

V2dha
Copy link
Contributor

@V2dha V2dha commented Jul 13, 2022

Fixes #2962

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #3332 (0bf8373) into master (337e41a) will increase coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head 0bf8373 differs from pull request most recent head b7f388b. Consider uploading reports for the commit b7f388b to get more accurate results

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   97.49%   97.76%   +0.27%     
==========================================
  Files         123      123              
  Lines        8861     8833      -28     
  Branches     3238     3219      -19     
==========================================
- Hits         8639     8636       -3     
+ Misses        222      197      -25     
Impacted Files Coverage Δ
lib/rules/jsx-no-target-blank.js 92.96% <100.00%> (+4.07%) ⬆️
lib/rules/forbid-prop-types.js 100.00% <0.00%> (ø)
lib/util/Components.js 98.96% <0.00%> (+2.48%) ⬆️
lib/util/jsx.js 95.60% <0.00%> (+3.29%) ⬆️
lib/rules/no-unstable-nested-components.js 98.25% <0.00%> (+3.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@V2dha V2dha requested a review from ljharb July 13, 2022 06:12
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lib/rules/jsx-no-target-blank.js Outdated Show resolved Hide resolved
lib/rules/jsx-no-target-blank.js Outdated Show resolved Hide resolved
lib/rules/jsx-no-target-blank.js Outdated Show resolved Hide resolved
tests/lib/rules/jsx-no-target-blank.js Outdated Show resolved Hide resolved
tests/lib/rules/jsx-no-target-blank.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Aug 4, 2022

@V2dha i've rebased this, and there's still 48 test failures - all things that expect an error but now get none. I think the some/every change may be related.

@ljharb ljharb merged commit b7f388b into jsx-eslint:master Aug 12, 2022
@V2dha V2dha deleted the jsx-no-blank branch August 12, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False negative when target and rel attributes are dynamic
2 participants