Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] forbid-dom-props: add disallowedFor option #3338

Merged
merged 1 commit into from Aug 4, 2022
Merged

[New] forbid-dom-props: add disallowedFor option #3338

merged 1 commit into from Aug 4, 2022

Conversation

TildaDares
Copy link
Contributor

Fixes #2946

@TildaDares TildaDares force-pushed the add-disallowed-forbid-dom-props branch from 8739748 to 94e98f5 Compare July 15, 2022 19:41
@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited

Codecov Report

Merging #3338 (d1835bc) into master (8baf0c5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d1835bc differs from pull request most recent head b3a3937. Consider uploading reports for the commit b3a3937 to get more accurate results

@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
- Coverage   97.72%   97.71%   -0.01%     
==========================================
  Files         123      123              
  Lines        8818     8795      -23     
  Branches     3208     3197      -11     
==========================================
- Hits         8617     8594      -23     
  Misses        201      201
Impacted Files Coverage Δ
lib/rules/forbid-dom-props.js 100.00% <100.00%> (ø)
lib/util/Components.js 98.92% <0.00%> (-0.05%) ⬇️
lib/rules/jsx-boolean-value.js 100.00% <0.00%> (ø)
lib/rules/require-default-props.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TildaDares TildaDares force-pushed the add-disallowed-forbid-dom-props branch from 94e98f5 to 77ed4af Compare July 15, 2022 19:44
@TildaDares
Copy link
Contributor Author

@ljharb Please review

ljharb
ljharb requested changes Jul 15, 2022
View reviewed changes
docs/rules/forbid-dom-props.md Outdated Show resolved Hide resolved
docs/rules/forbid-dom-props.md Outdated Show resolved Hide resolved
lib/rules/forbid-dom-props.js Outdated Show resolved Hide resolved
@TildaDares TildaDares requested a review from ljharb July 27, 2022 14:09
@ljharb ljharb force-pushed the add-disallowed-forbid-dom-props branch from d1835bc to b3a3937 Compare August 4, 2022 22:00
@ljharb ljharb changed the title Add option "disallowedFor" for dom element prop [New] forbid-dom-props: add disallowedFor option Aug 4, 2022
@ljharb ljharb merged commit b3a3937 into jsx-eslint:master Aug 4, 2022
@TildaDares TildaDares deleted the add-disallowed-forbid-dom-props branch August 5, 2022 06:13
@ljharb ljharb mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule option "disallowedFor" for component/dom element prop
2 participants
@TildaDares @ljharb