[Fix] no-unknown-property: No unknown property doesn't recognize svg properties #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3381 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 123 123
Lines 8954 8954
Branches 3268 3268
=======================================
Hits 8737 8737
Misses 217 217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
approved these changes
Sep 3, 2022
Comment on lines
+32
to
+34
| fill: ['svg'], | ||
| property: ['meta'], | ||
| viewBox: ['svg'], |
shepmaster
reviewed
Sep 3, 2022
| @@ -29,6 +29,9 @@ const DOM_ATTRIBUTE_NAMES = { | |||
| const ATTRIBUTE_TAGS_MAP = { | |||
| // image is required for SVG support, all other tags are HTML. | |||
| crossOrigin: ['script', 'img', 'video', 'audio', 'link', 'image'], | |||
| fill: ['svg'], | |||
There was a problem hiding this comment.
fill appears to be OK on a number of other tags, such as path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3380
I don't know if the added attributes are exhaustive or not. I sure hope MDN covered all possible attributes.