[New] jsx-no-leaked-render: add ignoreAttributes option

[aleclarson]

Fixes #3292

When ignoreAttributes is true, validation of JSX attribute values is skipped.

Todo

• write docs

[codecov]

Codecov Report

Merging #3441 (9c84be6) into master (b52e0ca) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #3441      +/-   ##
==========================================
- Coverage   97.62%   97.61%   -0.01%     
==========================================
  Files         123      123              
  Lines        8959     8970      +11     
  Branches     3272     3275       +3     
==========================================
+ Hits         8746     8756      +10     
- Misses        213      214       +1     

Impacted Files	Coverage Δ
lib/rules/jsx-no-leaked-render.js	97.33% <90.90%> (-1.11%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[levrik]

I think ignoreProps would be a more suitable name here.

[ljharb]

Can you elaborate on the use case here?

Certainly the component you're passing the prop value to might not be directly rendering it - but I'm not sure why that makes it OK to pass a renderable falsy value.

[aleclarson]

Can you elaborate on the use case here?

Certainly the component you're passing the prop value to might not be directly rendering it - but I'm not sure why that makes it OK to pass a renderable falsy value.

The use case is preferring to avoid false positives. The component receiving the prop is responsible for avoiding leaky render. Many prefer to keep the warning local to where the prop is actually rendered.

[ljharb]

I see - so you're saying, you still want to report on leaky renders on DOM elements, but you don't want to do that on props on custom elements so that the custom component has the responsibility to check for it?

In that case, what i'd expect is that this could be ignoreNonDOMProps, and it would only suppress warning on props of non-DOM elements - would that meet your use case?

[tcl333]

This rule is unusable to me until this PR is landed. I need to handle a very basic usecase of <Component isFooBar={isFoo && isBar}>. This rule currently auto-breaks that line by converting it into <Component isFooBar={isFoo ? isBar : null }>. My component doesn't take null as a prop, nor should it be required to.