[Fix] jsx-curly-brace-presence: handle single and only expression template literals
#3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate literals
Codecov Report
@@ Coverage Diff @@
## master #3538 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 132 132
Lines 9275 9282 +7
Branches 3389 3392 +3
=======================================
+ Hits 9053 9060 +7
Misses 222 222
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
approved these changes
Feb 25, 2023
ljharb
changed the title
jsx-curly-brace-presence: handle single and only expression template literals
This was referenced Jul 21, 2023
|
Hi @ljharb, I believe this change is wrong. This is a valid use case for stringifying a primitive (e.g., from number to string). Although you could do it via If you insist on keeping it as it is, I suggest putting it behind a flag 🙏. |
|
let me revert this now |
|
@Newbie012 yes, you're right, it should be reverted. |
ljharb
pushed a commit
to taozhou-glean/eslint-plugin-react
that referenced
this pull request
Jul 23, 2023
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
ljharb
pushed a commit
to taozhou-glean/eslint-plugin-react
that referenced
this pull request
Jul 24, 2023
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
ljharb
pushed a commit
to taozhou-glean/eslint-plugin-react
that referenced
this pull request
Jul 24, 2023
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
caesar1030
pushed a commit
to caesar1030/eslint-plugin-react
that referenced
this pull request
Dec 3, 2023
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3537