[New] jsx-no-literals: new config for allowedProps
#3588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3588 +/- ##
==========================================
- Coverage 97.62% 96.03% -1.60%
==========================================
Files 132 264 +132
Lines 9295 18566 +9271
Branches 3397 6784 +3387
==========================================
+ Hits 9074 17829 +8755
- Misses 221 737 +516
|
ljharb
requested changes
Jun 15, 2023
docs/rules/jsx-no-literals.md
Outdated
| @@ -116,6 +117,11 @@ var Hello = <Text {...props} /> | |||
| var Hello = <div class={xx} /> | |||
| ``` | |||
|
|
|||
| ```jsx | |||
| // an allowed property | |||
| var Hello = <div allowed='foo'>allowed</div> | |||
There was a problem hiding this comment.
Suggested change
| var Hello = <div allowed='foo'>allowed</div> | |
| var Hello = <div allowed="foo">allowed</div> |
ljharb
changed the title
jsx-no-literals: new config for allowedPropsjsx-no-literals: new config for allowedProps
|
I've rebased this. I think it needs to be per-component - I'd think you wouldn't want to allow a prop on every component, only on the specific component(s) that use that prop. |
|
It’s really unfortunate you deleted the fork; this PR is now unrecoverable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3003
This is adding a new property
allowedPropsto whitelist props allowed to have string literals. Some examples areclassidand etc.