Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-deprecated: false positive on commonjs import in no-deprecated rule #3614

Merged

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Aug 5, 2023

Fixes #3606

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #3614 (d73cd51) into master (0667fb0) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         132      132           
  Lines        9290     9298    +8     
  Branches     3395     3400    +5     
=======================================
+ Hits         9070     9078    +8     
  Misses        220      220           
Files Changed Coverage Δ
lib/rules/no-deprecated.js 99.09% <91.66%> (+0.06%) ⬆️

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! i ended up combining the check with the previous iteration.

@ljharb ljharb force-pushed the akul/fix-no-deprecated-false-positive branch 2 times, most recently from e76ade4 to d73cd51 Compare August 5, 2023 10:37
@ljharb ljharb merged commit d73cd51 into jsx-eslint:master Aug 5, 2023
290 of 291 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: false positive on commonjs imports for no-deprecated
2 participants