[New] forward-ref-uses-ref: add rule for checking ref parameter is added
#3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3667 +/- ##
=======================================
Coverage 97.74% 97.75%
=======================================
Files 132 133 +1
Lines 9409 9437 +28
Branches 3449 3458 +9
=======================================
+ Hits 9197 9225 +28
Misses 212 212 ☔ View full report in Codecov by Sentry. |
ljharb
reviewed
Dec 15, 2023
NotWoods
force-pushed
the
forward-ref-uses-ref
branch
from
b706ee7
to
40e8658
Compare
ljharb
reviewed
Dec 16, 2023
ljharb
requested changes
Dec 20, 2023
ljharb
reviewed
Dec 20, 2023
ljharb
reviewed
Dec 20, 2023
NotWoods
force-pushed
the
forward-ref-uses-ref
branch
from
9837ead
to
cc19659
Compare
|
(there's still some uncovered lines) |
|
I'll work on this more in January; currently busy with holidays. Will make sure to get the last few lines covered and see if I can figure out why ESLint 6 & 7 are failing. |
NotWoods
force-pushed
the
forward-ref-uses-ref
branch
from
cc19659
to
2f921af
Compare
ljharb
reviewed
Jan 31, 2024
|
I don't see the uncovered lines in Codecov, can you help point them out to me? |
|
@NotWoods they're right in the "files changed" tab - see https://github.com/jsx-eslint/eslint-plugin-react/pull/3667/files#diff-25114be5f5c5bf7d89a5cc5dfb905ca0d6aafda4a7cb7b49d20df89ceea52bf4R72 for an example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3158
Adds a new rule to require that a second parameter is used with
forwardRef. Offers suggestions to add the parameter or remove theforwardRefwrapper.