Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eslint ^9 #3726

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

li-jia-nan
Copy link

feat: support eslint ^9

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (e4ecbcf) to head (4b94a6b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3726   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         133      133           
  Lines        9467     9467           
  Branches     3467     3467           
=======================================
  Hits         9255     9255           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Standard8
Copy link

I'm not a maintainer here, but this doesn't seem to be enough - see the comments on issue #3699

@li-jia-nan
Copy link
Author

Sorry, I didn't notice that there was already an issue here, I closed this PR.

@li-jia-nan li-jia-nan closed this Apr 6, 2024
@Standard8
Copy link

Oh, sorry, I don't think you have to close it, but it does seem there's a bit more work than just bumping the compatible versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants