Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Handle function calls in TSNonNullExpression #129

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Jun 16, 2023

Handle code like:

return (<img
  src={getInfo(resource)!.image}
/>);

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #129 (6bffdd6) into main (a0f4f38) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 6bffdd6 differs from pull request most recent head 26cc3c4. Consider uploading reports for the commit 26cc3c4 to get more accurate results

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   94.59%   94.63%   +0.04%     
==========================================
  Files          37       37              
  Lines         370      373       +3     
  Branches      127      128       +1     
==========================================
+ Hits          350      353       +3     
  Misses         20       20              
Impacted Files Coverage Δ
src/values/expressions/TSNonNullExpression.js 77.50% <100.00%> (+1.82%) ⬆️

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the method_calls_in_ts_non_null branch from 6bffdd6 to 26cc3c4 Compare June 28, 2023 15:14
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, thanks!

@ljharb ljharb merged commit 26cc3c4 into jsx-eslint:main Jun 28, 2023
270 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants