New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support apikey resource #48
Conversation
@fgouteroux Thanks! If the vendor / client library needs modified then yeah, it'll need to be done in a PR for that repo. The |
@fgouteroux Here's the documentation about vendoring with Go modules: https://golang.org/ref/mod#vendoring Let me know if you have any questions about it. Vendoring isn't absolutely required, but it was used in some other projects I used to help with, so I carried the pattern over. |
Thanks for the explanation. In the meanwhile I have open the PR sensu/sensu-go#4336 I'm not sure if sensu will accept it and when. Concerning the ci test failing I tried with sensu 6 and the test is passing. I don't Know why maybe the sensu version as in ci this is the version 5.21 but i'm not sure |
@fgouteroux Sounds good. I'll poke around with the CI tests and see if I can figure it out. 🙂 |
@jtopjian good news, sensu have accepted and merged the PR sensu/sensu-go#4336. So I've updated the go.mod file and I got the error
As explained here etcd-io/etcd#12124, I add a replace statement to fix the error. Let me know if it's ok. |
@fgouteroux I'm very sorry for the late reply. I think the This PR looks good to me. Let me know if you wanted to do any additional work or if it's good to merge. |
@jtopjian no worries, it's ok for the merge |
Hi @jtopjian
Adding support of apikey management.
However I have a question: does I need to open a PR to https://github.com/sensu/sensu-go to update the apikey client file, or the update of vendor file is enough (vendor/github.com/sensu/sensu-go/cli/client/apikey.go)
Also CI is failing, when updating the username of apikey, I cannot reproduce it in my environment. Do you have some idea ?