Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Node.js 20 Failures for API / Frisby Tests #2070

Merged

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Aug 27, 2023

Description

Set's ignore on failure to true for Node.js 20.

This at least allows us to continue the ci after the failure.

Related (but doesn't fix) #2068

Affirmation

Signed-off-by: Jannik Hollenbach <jannik@hollenbach.de>
Signed-off-by: Jannik Hollenbach <jannik@hollenbach.de>
@cypress
Copy link

cypress bot commented Aug 27, 2023

Passing run #286 ↗︎

0 218 16 0 Flakiness 0

Details:

Simplify setting NODE_ENV=test env var across operating systems
Project: OWASP Juice Shop Commit: 2e3e03dc92
Status: Passed Duration: 56:08 💡
Started: Aug 27, 2023 10:35 AM Ended: Aug 27, 2023 11:31 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Aug 27, 2023

Passing run #287 ↗︎

0 218 16 0 Flakiness 0

Details:

Merge 2e3e03d into 39678eb...
Project: OWASP Juice Shop Commit: c493e21ffc ℹ️
Status: Passed Duration: 10:51 💡
Started: Aug 27, 2023 10:36 AM Ended: Aug 27, 2023 11:47 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@bkimminich bkimminich merged commit 9cec7ac into develop Aug 27, 2023
55 of 61 checks passed
@J12934 J12934 deleted the maintanace/ignore-node-20-failures-for-frisby-tests branch August 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants