Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Update eslint to v4 #3008

Merged
merged 4 commits into from Jun 15, 2017
Merged

Update eslint to v4 #3008

merged 4 commits into from Jun 15, 2017

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Jun 15, 2017

  • In eslint v4 they rewrote the indent rule to make it more strict and we had a lot of improperly indented code.
  • Indent changes were fixed with --fix
  • --cache was removed from eslint command as it kept getting out of sync. It can probably be re-enabled in the future.
  • I wasn't able to update eslint-react-plugin because of a bug when assigning props to another variable: https://github.com/yannickcr/eslint-plugin-react/issues/1257

@hatched hatched added the devops label Jun 15, 2017
@hatched hatched added this to the kinky kirk milestone Jun 15, 2017
@jujugui
Copy link
Contributor

jujugui commented Jun 15, 2017

Refer to this link for build results (access rights to CI server needed):
http://ci-cge.jujugui.org:8080//job/juju-gui/7803/

@jujugui
Copy link
Contributor

jujugui commented Jun 15, 2017

Refer to this link for build results (access rights to CI server needed):
http://ci-cge.jujugui.org:8080//job/juju-gui/7804/

Copy link
Contributor

@makyo makyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many spaces! LGTM

@hatched
Copy link
Contributor Author

hatched commented Jun 15, 2017

Thanks @makyo

:shipit:

@jujugui
Copy link
Contributor

jujugui commented Jun 15, 2017

Status: merge request accepted. Url: http://ci-gce.jujugui.org:8080/job/juju-gui-merge

@jujugui jujugui merged commit bdc21d1 into juju:develop Jun 15, 2017
@hatched hatched deleted the update-eslint-4 branch June 15, 2017 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants