Use CONCAT for injecting LIKE parameters; #17346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
|
Please extend the PR description and title to more accurately explain what this PR does and why it is changing something. |
ycliuhw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we can just do
WHERE sruc.unit_id LIKE '$M.app_name/%', but sqlair ignores parameters in quotes, then SQLite complains:invalid input parameter: argument of type "M" not used by query.I opened an issue: canonical/sqlair#148, @Aflynn50 suggested we can use CONCAT as a workaround.
So I have this PR to fix the TODO.
There is no feature changes on this PR.
QA step: #17264